fix(controller): ensure iteration on capsule ownerreferences#1059
Merged
oliverbaehler merged 1 commit intoprojectcapsule:mainfrom May 2, 2024
Merged
fix(controller): ensure iteration on capsule ownerreferences#1059oliverbaehler merged 1 commit intoprojectcapsule:mainfrom
oliverbaehler merged 1 commit intoprojectcapsule:mainfrom
Conversation
oliverbaehler
changed the title
✅ Deploy Preview for capsule-documentation canceled.
|
oliverbaehler
force-pushed
the
fix/multi-owners
branch
2 times, most recently
from
e8dfa83 to
b23ba8a
Compare
prometherion
reviewed
May 1, 2024
Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
oliverbaehler
force-pushed
the
fix/multi-owners
branch
from
b23ba8a to
cde6e15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While automating capsule for a HCI solution i noticed we have this bug. If you try to add another ownerreference you are always met with this error:
fx9kggjwjdis representative for the new ownerreference name added. This fix checks if the ownerreference is actually from a tenant, if not it's skipped.